[4.1 -> main] update various CI workflow action versions; meeting new requirement of asset-artifact-download-action #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[4.1] update various CI workflow action versions; meeting new requirement of `asset-artifact-download-action`
heifner
approved these changes
Jul 1, 2024
greg7mdp
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main merge of #296:
When fixing #291,
asset-artifact-download-action@v3happened to be modified in a way that it does anHTTP HEADon the artifact payload (AntelopeIO/asset-artifact-download-action@589a841).Unfortunately it turns out that
HTTP HEADrequests on artifact payloads only seem to work when using the newer artifact mechanics provided byactions/upload-artifact@v4, thus causing spring workflows to fail to find a cdt artifact (https://github.com/AntelopeIO/spring/actions/runs/9744641333/job/26897606178) since cdt is still usingv3. I hadn't noticed this in testing since the spring repo is using versionv4for a while now.Upgrade to
actions/upload-artifact@v4so that spring, etc can find cdt when using a git ref1. And go ahead and update other actions in here that will get rid of all the deprecation warnings that are flagged.Footnotes
Older release branches of
leapuse released cdt versions -- getting those aren't affected by thisHTTP HEADissue so there isn't a need to push this change back further than cdt's 4.1 branch ↩